Skip to content

Conversation

@jvllmr
Copy link
Contributor

@jvllmr jvllmr commented Nov 7, 2025

Updated the instrumentation package table to indicate that the Gin Gonic framework supports both metrics and traces. I initially thought that it does not support metrics until I saw that it was already implemented in #6747. 😅

Updated the instrumentation package table to indicate that the Gin Gonic framework supports both metrics and traces. I initially thought that it does not support metrics until I saw that it was already implemented in open-telemetry#6747.
@jvllmr jvllmr requested a review from a team as a code owner November 7, 2025 19:13
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 7, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: dmathieu / name: Damien Mathieu (814f9d4)

@dmathieu dmathieu added the Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG label Nov 10, 2025
@codecov
Copy link

codecov bot commented Nov 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.8%. Comparing base (d11eceb) to head (814f9d4).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #8143   +/-   ##
=====================================
  Coverage   81.8%   81.8%           
=====================================
  Files        194     194           
  Lines      13380   13380           
=====================================
  Hits       10954   10954           
  Misses      2029    2029           
  Partials     397     397           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@flc1125
Copy link
Member

flc1125 commented Nov 10, 2025

In fact, not only otelgin, but several other components also provide support for metrics.

Would you be willing to update the latest status of the other components together?

@jvllmr jvllmr changed the title otelgin: update readme to indicate metrics support chore: update metrics support in instrumentation readme Nov 10, 2025
@jvllmr
Copy link
Contributor Author

jvllmr commented Nov 10, 2025

In fact, not only otelgin, but several other components also provide support for metrics.

Would you be willing to update the latest status of the other components together?

Thanks for the hint @flc1125. I have taken a look at the other instrumentation modules and update the PR. 👍🏻

@jvllmr
Copy link
Contributor Author

jvllmr commented Nov 10, 2025

Related PRs are #6648 and #7668.

@jvllmr jvllmr requested a review from flc1125 November 10, 2025 22:10
@dmathieu dmathieu merged commit 83656e5 into open-telemetry:main Nov 12, 2025
43 of 44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants